Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building DllImportGeneratorSample #61806

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fix building DllImportGeneratorSample #61806

merged 1 commit into from
Nov 18, 2021

Conversation

elinor-fung
Copy link
Member

Remove the project reference to DllImportGenerator - rely on generators.targets to add it instead.

@AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added this to the 7.0.0 milestone Nov 18, 2021
@elinor-fung
Copy link
Member Author

Merging, since CI doesn't matter for this.

@elinor-fung elinor-fung merged commit bd63cfc into dotnet:main Nov 18, 2021
@elinor-fung elinor-fung deleted the dllImportGeneratorSampleBuild branch November 18, 2021 20:14
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkoritzinsky @AaronRobinsonMSFT